Fix closestGroup race condition in RemoteResourceIndex #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull #194 introduced a closestGroup field in RemoteResourceIndex. However the group object is request-specific and so the values should not be shared between multiple threads. The resulting race condition frequently causes intermittent 404 errors preventing resources from loading with this message logged: Apr 19, 2015 10:52:03 PM org.archive.wayback.webapp.AccessPoint handleReplay WARNING: (1)LOADFAIL: Self-Redirect: No Closest Match Found /20140309082106/http://catalogue.nla.gov.au/js/barcode.js?1225315091 Apr 19, 2015 10:52:03 PM org.archive.wayback.webapp.AccessPoint logError WARNING: Runtime Error org.archive.wayback.exception.ResourceNotAvailableException: Self-Redirect: No Closest Match Found This change replaces the closestGroup field with a local variable thus ensuring it cannot be overwritten by other threads.
johnerikhalse
added a commit
that referenced
this pull request
Oct 5, 2015
Fix closestGroup race condition in RemoteResourceIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #194 introduced a closestGroup field in RemoteResourceIndex. However the group object is request-specific and so the values should not be shared between multiple threads. The resulting race condition frequently causes intermittent 404 errors preventing resources from loading with this message logged:
This change replaces the closestGroup field with a local variable thus ensuring it cannot be overwritten by other threads.