Set exclusionFilter on wbRequest via AccessPoint only if not already set #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngenie
added a commit
to kngenie/wayback
that referenced
this pull request
Sep 25, 2015
test will succeed when iipc#287 is merged.
kris-sigur
pushed a commit
that referenced
this pull request
Sep 30, 2015
Set exclusionFilter on wbRequest via AccessPoint only if not already set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would fix issue #259.
Modifies
AccessPointto check if theWebRequestinstance already hasexclusionFilterset (not to null) to determine if it should callcreateExclusionFilter(). This way, ifAccessControlSettingOperationsets anexclusionFilter, it will not get overwritten.