URLParser and WaybackURLKeyMaker fail on URLs with IPv6 address hostname #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs/URIs with an IPv6 address as host fail to parse by URLParser. Consequently, WaybackURLKeyMaker fails to make the SURT key:
This PR fixes the parser failure. Enclosing
[
and]
are stripped from the IPv6 hosts to stay compatible with SURT keys generated by the Python surt module: