Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration override is not possible. Please provide a flag #1860

Closed
3 tasks done
julianxhokaxhiu opened this issue Sep 9, 2017 · 4 comments
Closed
3 tasks done

Comments

@julianxhokaxhiu
Copy link
Contributor

I agree and want to create new issue


Hi,

I am contacting you because I really like this theme but I found something that could improve the usage of this theme, especially is you use it as a submodule.

What I basically need is a way to override totally the menu structure with my custom links. Although at the current status the default _config.yml defines a Home link which I can't remove/override. Also, since Hexo has the issue that languages cannot be overridden outside of the theme, I am basically stuck with the "Home" labelling even If I don't need it like that.

What I purpose is providing a flag in _data/next.yml that allows the user to decide if to merge the configs or to override them.

Thank you and best regards,
Julian

Expected behavior

When using _data/next.yml the configuration is fully overridden.

Actual behavior

When using _data/next.yml the configuration is merged.

Steps to reproduce the behavior

  1. Try to comment the menu section.
  2. Run hexo clean && hexo generate
  3. Run hexo server

NexT Information

NexT Version:

[x] Latest Master branch.
[] Latest Release version.
[] Old version - 

NexT Scheme:

[] All schemes
[] Muse
[x] Mist
[] Pisces
[] Gemini

Other Information

$ hexo --version
hexo: 3.3.9
hexo-cli: 1.0.3
...
@nielinjie
Copy link

Hexo has a way to override theme config, why NEXT design another way? Have I miss anything here?
hexojs/hexo#757

@julianxhokaxhiu
Copy link
Contributor Author

Fair enough, I was not aware of that. Willing to create a dedicated MR?

@ivan-nginx
Copy link
Collaborator

@nielinjie yes, please create new issue. Maybe need to do global refactoring in override option.

@nielinjie
Copy link

#2006

wafer-li pushed a commit to wafer-li/hexo-theme-next that referenced this issue Dec 29, 2017
Repository owner locked as resolved and limited conversation to collaborators Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants