Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replace swig template engine #1892

Closed
3 tasks done
Haocen opened this issue Sep 19, 2017 · 5 comments
Closed
3 tasks done

Consider replace swig template engine #1892

Haocen opened this issue Sep 19, 2017 · 5 comments

Comments

@Haocen
Copy link
Contributor

Haocen commented Sep 19, 2017

I agree and want to create new issue


Expected behavior

Actual behavior

Steps to reproduce the behavior

  1. N/A
  2. N/A
  3. N/A
  • Link to demo site with this issue: N/A
  • Link(s) to source code or any usefull link(s): N/A

NexT Information

NexT Version:

[x] Latest Master branch.
[x] Latest Release version.
[x] Old version - 

NexT Scheme:

[x] All schemes
[] Muse
[] Mist
[] Pisces
[] Gemini

Other Information

According to https://github.com/paularmstrong/swig/

swig template engine is no longer maintained, we should consider switching to another template engine.

ejs seemed has similar syntax and is going to stick around for a while, I propose to use ejs as a replacement.

@ivan-nginx
Copy link
Collaborator

Yeah, i know it. But it's hardly and need very big time to refactoring from swig to ejs and at most cases swig for now work fine. And there is one thing anyway: hexo also use swig as default template and as i know they not want for now to migrate to any another.
If u can and want, u may do it in separated test branch. Or anyone? Who want to do it, please, welcome!

@Neveryu
Copy link

Neveryu commented Sep 26, 2017

oh,no.wish you can do it finish..

@AlynxZhou
Copy link
Contributor

@ivan-nginx Recently I found nunjucks's syntax is similiar to swig, if we have plan to migrate in future, I think nunjuck is a better choice than ejs. XD

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Nov 22, 2017

There are many rendering engines, not only ejs, jade or swig. For example, mustache have similar syntax too. But i don't know why we must use mainstream rendering. Swig is work fine and no have any critical bugs. And remake rendering engine will make some special troubles and additional bugs in future.

Anyway, if there will be strong arguments about replace template engine, we can try to implement it. But question is still open: who will do it? It will take a lot of time and i'm not sure what anybody will do it for free.

P.S. If anybody want to use ejs, he can use any other a lot of themes like yilia, material or tranquilpeak. But, ahah, u see this syntax? How about me, a don't like <%- and %>, this so ugly looks and bad for main vision. Look on TQ layout, for example. And look on NexT layout. See the difference?

@ivan-nginx
Copy link
Collaborator

Already replaced swig by swig-templates in this pull and released in Hexo v3.5.0 and tested with NexT v6.

Repository owner locked as resolved and limited conversation to collaborators Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants