Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(swig): replace swig by swig-templates #2949

Merged
merged 1 commit into from
Jan 14, 2018
Merged

refactor(swig): replace swig by swig-templates #2949

merged 1 commit into from
Jan 14, 2018

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Jan 7, 2018

Fixes #2939
Fixes #2919

Replaced swig by swig-templates to mitigate uglifyjs 2.4 security vulnerability.

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Jan 7, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.249% when pulling db1bb1e on use-swig-templates into f19629e on master.

@JLHwung JLHwung added this to the 3.5.0 milestone Jan 7, 2018
@JLHwung JLHwung requested a review from celsomiranda January 9, 2018 05:03
@tomap tomap mentioned this pull request Jan 9, 2018
Closed
@JLHwung JLHwung merged commit b0c6508 into master Jan 14, 2018
@JLHwung JLHwung deleted the use-swig-templates branch January 14, 2018 02:28
This was referenced Mar 15, 2018
Closed
Closed
Closed
ivan-nginx added a commit to theme-next/hexo-theme-next that referenced this pull request Apr 13, 2018
@ivan-nginx
Minimal correct support for NexT is Hexo v3.5.0 for now.
4174f50 
1. Replaced swig by swig-templates to mitigate uglifyjs 2.4 security vulnerability: hexojs/hexo#2949
2. Additional templates support which will be used in next NexT releases.
3. You can still use old Hexo versions, but will not guarantee to correct NexT rendering.
@stevenjoezhang stevenjoezhang mentioned this pull request Oct 29, 2019
Closed
sslogan666 pushed a commit to sslogan666/sslogan666.github.io that referenced this pull request Jun 12, 2021
@ivan-nginx @sslogan666
Minimal correct support for NexT is Hexo v3.5.0 for now.
96e51cf 
1. Replaced swig by swig-templates to mitigate uglifyjs 2.4 security vulnerability: hexojs/hexo#2949
2. Additional templates support which will be used in next NexT releases.
3. You can still use old Hexo versions, but will not guarantee to correct NexT rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celsomiranda celsomiranda Awaiting requested review from celsomiranda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JLHwung @coveralls