Spaced string in imgTag

[ianrose]

Hexo v3.0

Using the img tag plugin the Alt attribute gets rendered as part of the the title attribute.

Example code used to test:

{% img class-name /path/to/image 100 100 "Title" "Alt" %}

HTML Output

<img src="/path/to/image" class="class-name" width="100" height="100" title="Title Alt">

[chenneal]

I have the question the same as you don‘t sloved， i don't know the reason.

[PhiLhoSoft]

I looked into the source code.
plugins/tag/img.js -> function imgTag(args, content)
content is not used, args is populated with a naive split on space of the content of the tag (minus the name of the tag itself, of course).
"Naive" because if you type two spaces in the tag, that will make an empty arg and will shift the next ones, so everything is off.
Moreover, the split removed all quotes!
So, if I have the tag:
{% img /assets/images/Work-in-Progress.svg 240 75 "Work in Progress" "Work in Progress" %}
I get the array:

[ '/assets/images/Work-in-Progress.svg',
  '240', // Here I got another '', because I added a space between the two numbers...
  '75',
  'Work',
  'in',
  'Progress',
  'Work',
  'in',
  'Progress' ]

Once the dimensions are processed, the code does: meta = args.join(' '); to get back the title and alt attributes together, then use a regular expression (expecting quoted strings) to split them again.
Problem: there is no longer any quotes, so all we get is the title itself. 😢

To fix that, I have to look how the content of a tag is split...

PS.: The problem dates back to May 16! Nobody had the time to fix that? (I know, that's something that can be done by contributors...)

[PhiLhoSoft]

OK, I found a workaround...
Just use both kinds of quotes around your title and alt strings!
{% img /assets/images/Work-in-Progress.svg 240 75 '"Work in Progress"' '"Work in Progress"' %}
or
{% img /assets/images/Work-in-Progress.svg 240 75 "'Work in Progress'" "'Work in Progress'" %}

Apparently, it might be Swig's fault for bad parsing of the parameters...

[chenneal]

@PhiLhoSoft thanks very much, it's looks works through your workaround.

[PhiLhoSoft]

@Xuanwo Why did you close this issue? It is not solved at all! I just gave a workaround.
At best, you find a way to make it work as expected, ie. with regular (not doubled) quotes. Might need something on Hexo side, or something on Swig side, from monkey patching the faulty function, to opening an issue at this project.
At worst, this needs at least a documentation update to tell users to use the workaround...

[Xuanwo]

Sorry for miss leading for closing the issue when I hadn't read it.

I close the issues through the mail #1277 (comment) which I thought sloved.

[tomap]

Maybe this PR will solve your issue ? #2949

[curbengh]

imgTag first parse title and alt from the 6th argument, then split them.

hexo/lib/plugins/tag/img.js

Line 13 in f37557a

* {% img [class names] /path/to/image [width] [height] [title text [alt text]] %}

{% img class-name /path/to/image 100 100 '"Title" "Alt"' %}

Note the usage is different from the previous comment, as there is only one pair of single quote.

The doc also shows title and alt are parsed from the 6th argument.

{% img [class names] /path/to/image [width] [height] "title text 'alt text'" %}

This means imgTag doesn't support parsing alt from the 7th argument.