Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented avatar not visible in sidebar for now. #1837

Merged
merged 3 commits into from
Aug 30, 2017
Merged

Commented avatar not visible in sidebar for now. #1837

merged 3 commits into from
Aug 30, 2017

Conversation

ivan-nginx
Copy link
Collaborator

@ivan-nginx ivan-nginx commented Aug 30, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Default avatar loading if avatar option commented.
Issue Number(s): #1789.

What is the new behavior?

Default avatar not loading if avatar option commented.

How to use?

In NexT _config.yml:

#avatar: /images/avatar.gif

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx ivan-nginx added this to the v5.1.3 milestone Aug 30, 2017
@ivan-nginx ivan-nginx merged commit d8274e5 into iissnan:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant