Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translation #1863

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Add Italian translation #1863

merged 1 commit into from
Sep 9, 2017

Conversation

julianxhokaxhiu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • New translation

What is the current behavior?

Issue Number(s): N/A

What is the new behavior?

Add Italian language support

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx
Copy link
Collaborator

OMG stop it :)

@julianxhokaxhiu
Copy link
Contributor Author

Sorry, I think I'm pretty done with this one :D Adapting Next to my blog had some requirements :P

@ivan-nginx ivan-nginx merged commit 98237f9 into iissnan:master Sep 9, 2017
@julianxhokaxhiu julianxhokaxhiu deleted the feature/add-italian-language branch September 9, 2017 09:23
@ivan-nginx
Copy link
Collaborator

U can make big pull with all changes. It can be find as Big pull request template in PULL_REQUEST_TEMPLATE: just comment standart template and uncomment big template with <!-- -->. See example of big pulls there (Fixes and enhancements. [XX]).

@julianxhokaxhiu
Copy link
Contributor Author

Ah ok, well, I usually prefer to split PR in small chunks anyway. Much easier to review them :D

But If I annoy with this attitude, I'll go for big PR next time :) Thanks!

@ivan-nginx
Copy link
Collaborator

I usually do small PR's, but something big templates looks better and easy to edit errors i think. U can do templates any u want, but see on big template — mb it will better for u, who knows.

@ivan-nginx ivan-nginx added this to the v5.1.3 milestone Sep 9, 2017
@ivan-nginx ivan-nginx added the i18n label Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants