Added embroider-safe to ember-try scenarios #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I followed the Addon Author Guide to understand what I could do to prepare for Embroider landing.
I wanted to add both
embroider-safe
andembroider-optimized
scenarios, but the latter wouldn't pass in CI. There may be two explanations:I was using v0.4.0 of
ember-element-helper
.Updating the addon to v0.5.0 (in Updated ember-element-helper to v0.5.0 #80) fixed the error above.
ember-css-modules
, which is used in the demo app, is not compatible with Embroider yet (Embroider compatibility salsify/ember-css-modules#140, Embroider with staticComponents: true not working with pods components salsify/ember-css-modules#160)I tried changing the demo app's
components
folder structure from nested to flat, in case this might help Embroider understandember-css-modules
. Changing the folder structure didn't seem to have an effect.For now, let's check just the
embroider-safe
scenario.References
@ember/test-setup
ember-element-helper