Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to exclude ROS packages from build #12

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Add option to exclude ROS packages from build #12

merged 4 commits into from
Oct 11, 2023

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Sep 22, 2023

  • sometimes it is not desired to build all packages that are potentially also included from other repositories via .repos
  • a new option is introduced to blacklist certain ROS packages and thereby exclude them from the dev image and from being built for the run image
  • the blacklisted packages are deleted during the image building process

lreiher
lreiher commented Sep 22, 2023
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@jpbusch jpbusch force-pushed the feature/package-blacklist branch from e2e6721 to 54df86f Compare October 11, 2023 13:52
jpbusch
jpbusch previously approved these changes Oct 11, 2023
View reviewed changes
@lreiher lreiher merged commit 91fd3b3 into main Oct 11, 2023
0 of 10 checks passed
@lreiher lreiher deleted the feature/package-blacklist branch October 11, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbusch jpbusch jpbusch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lreiher @jpbusch