Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workspace such that docker-ros-generated images can be used as base images for docker-ros #39

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

lukaszanger
Copy link
Collaborator

The following modifications are necessary to enable the usage of docker-ros-generated images, which already have their install space and their src folder, as base images for docker-ros:

  • Create new bash script .install-dependencies.sh for a newly started pipeline run instead of appending an existing one.
  • If the install space already exists in the scope of the base image (docker-ros-generated), move this install space in order to make space for a new one.
  • Remove potentially existing src folder which might exist in the scope for the base image (docker-ros-generated).
  • Source from both, from the moved install space coming from the base image (docker-ros-generated) and from the newly created install space.

@lukaszanger lukaszanger added the enhancement New feature or request label Nov 19, 2024
@lukaszanger lukaszanger self-assigned this Nov 19, 2024
lreiher
lreiher previously approved these changes Nov 19, 2024
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Lennart Reiher <lennart.reiher@ika.rwth-aachen.de>
lukaszanger and others added 2 commits November 19, 2024 13:34
Co-authored-by: Lennart Reiher <lennart.reiher@ika.rwth-aachen.de>
@lreiher
Copy link
Member

lreiher commented Nov 19, 2024

Upgrade version after CI has succeeded, then merge

@lreiher lreiher merged commit e6f626d into main Nov 19, 2024
2 of 6 checks passed
@lreiher lreiher deleted the fix-workspace branch November 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants