Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options to run custom scripts at multiple points in the build stages #50

Merged
merged 14 commits into from
Feb 5, 2025

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Jan 23, 2025

  • introduces new configuration variables to specify custom scripts that run at different points in the build process
    • BEFORE_DEPENDENCY_IDENTIFICATION_SCRIPT: runs in dependencies stage after basic setup, before .repos are cloned
    • BEFORE_DEPENDENCY_INSTALLATION_SCRIPT: runs in dependencies-install stage as first step in .install-dependencies.sh
    • AFTER_DEPENDENCY_INSTALLATION_SCRIPT: runs in dependencies-install stage as last step in .install-dependencies.sh
  • CUSTOM_SCRIPT_FILE effectively has been renamed to AFTER_DEPENDENCY_INSTALLATION_SCRIPT, but still defaults to docker/custom.sh
  • this feature should add a lot more customizability of the build process, useful/required for, e.g., setting up private apt repositories (closes Is it possible to add a private debian repository? #23, closes Adding Rosdep Sources Before Rosdep Install #49)

@lreiher lreiher requested a review from jpbusch January 23, 2025 13:37
.gitlab-ci/docker-ros.yml Outdated Show resolved Hide resolved
@lreiher lreiher requested a review from jpbusch January 31, 2025 14:53
@lreiher
Copy link
Member Author

lreiher commented Jan 31, 2025

To be tested with arm64/ros-monitoring by @lukaszanger before merging.

jpbusch
jpbusch previously approved these changes Feb 5, 2025
@lreiher lreiher dismissed jpbusch’s stale review February 5, 2025 11:54

The merge-base changed after approval.

@lreiher lreiher merged commit 7e7f46a into main Feb 5, 2025
6 checks passed
@lreiher lreiher deleted the more-custom-scripts branch February 5, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Rosdep Sources Before Rosdep Install Is it possible to add a private debian repository?
2 participants