Dockerfile: Check ROS_VERSION when adding repos

[yaymalaga]

This fixes library incompatibilities while installing dependencies

[jpbusch]

Thank you for your contribution, @yaymalaga!

Since docker-ros is also supposed to work with base images in which the ROS_VERSION variable is not set and noetic is the only non-EOL distro for ROS 1, I would suggest checking only for ROS_DISTRO, which implies ROS_VERSION=1.

Apart from that, it would be interesting to know which incompatibilities have occurred in your case. Could you please describe the problem briefly?

[jpbusch]

Could you please also modify the GitHub actions .github/workflows such that the checks also run on PRs? Apparently we have set it up incorrectly, as no checks are currently being tested in this PR.

Simply change the on key to this:

on: [push, pull_request]

[yaymalaga]

Since docker-ros is also supposed to work with base images in which the ROS_VERSION variable is not set and noetic is the only non-EOL distro for ROS 1, I would suggest checking only for ROS_DISTRO, which implies ROS_VERSION=1.

That's sound like a good option yeah!

Apart from that, it would be interesting to know which incompatibilities have occurred in your case. Could you please describe the problem briefly?

I was having unmet dependencies related to Gazebo, as shown below, which simply disappeared after remove the ROS1 repos:

#27 469.5  gazebo : Depends: libgazebo11 (= 11.10.2+dfsg-1) but 11.11.0-1~focal is to be installed
#27 469.5  libgazebo-dev : Depends: libignition-transport8-dev but it is not going to be installed
#27 469.5                  Depends: libignition-msgs5-dev (>= 5.1) but it is not going to be installed
#27 469.5                  Depends: libignition-common3-dev (>= 3.14.0+dfsg-3) but it is not going to be installed
#27 469.5                  Depends: libignition-fuel-tools4-dev but it is not going to be installed
#27 469.5                  Depends: libgazebo11 (= 11.10.2+dfsg-1) but 11.11.0-1~focal is to be installed
#27 469.5  libgazebo11 : Depends: libboost-filesystem1.71.0 but it is not installable
#27 469.5                Depends: libboost-iostreams1.71.0 but it is not installable
#27 469.5                Depends: libboost-program-options1.71.0 but it is not installable
#27 469.5                Depends: libboost-regex1.71.0-icu66 but it is not installable
#27 469.5                Depends: libboost-thread1.71.0 but it is not installable
#27 469.5                Depends: libbullet2.88 (>= 2.88+dfsg) but it is not installable
#27 469.5                Depends: libdart6 (>= 6.9.2) but it is not installable
#27 469.5                Depends: libdart6-collision-bullet (>= 6.9.2) but it is not installable
#27 469.5                Depends: libgdal26 (>= 3.0.0) but it is not installable
#27 469.5                Depends: libignition-fuel-tools4 (>= 4.4.0) but it is not going to be installed
#27 469.5                Depends: libignition-msgs5 (>= 5.9.0) but it is not going to be installed
#27 469.5                Depends: libignition-transport8 (>= 8.2.1) but it is not going to be installed
#27 469.5                Depends: libprotobuf17 but it is not installable
#27 469.5                Depends: libtinyxml2-6a (>= 6.0.0) but it is not installable
#27 469.5 E: Unable to correct problems, you have held broken packages.

Also, thanks for making the changes, I completely forgot about the PR until I saw the notification just now.

[lreiher]

Thanks for getting back to this! We have already integrated the changes because we were in a bit of a hurry to push a new release.

We are now going to merge this and create a new release. Please note that the GitHub action checks have not succeeded, because the required GitHub action secrets are not shared with pull requests from repository forks.