Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor conversion node #24

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Refactor conversion node #24

merged 13 commits into from
Jul 10, 2024

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Jul 10, 2024

  • refactor conversion node for better extensibility to more message types
  • add parameter for subscriber/publisher queue size
  • all message types were successfully tested in conversion node

@lreiher lreiher requested a review from jpbusch July 10, 2024 09:43
@lreiher
Copy link
Member Author

lreiher commented Jul 10, 2024

Somehow this also solves all remaining memory leaks after #21.

==381575== HEAP SUMMARY:
==381575==     in use at exit: 505,389 bytes in 139 blocks
==381575==   total heap usage: 9,105 allocs, 8,966 frees, 14,526,878 bytes allocated
==381575== 
==381575== LEAK SUMMARY:
==381575==    definitely lost: 0 bytes in 0 blocks
==381575==    indirectly lost: 0 bytes in 0 blocks
==381575==      possibly lost: 0 bytes in 0 blocks
==381575==    still reachable: 505,389 bytes in 139 blocks
==381575==         suppressed: 0 bytes in 0 blocks
==381575== Reachable blocks (those to which a pointer was found) are not shown.
==381575== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==381575== 
==381575== For lists of detected and suppressed errors, rerun with: -s
==381575== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

@lreiher lreiher mentioned this pull request Jul 10, 2024
@lreiher lreiher merged commit cbe3945 into main Jul 10, 2024
15 checks passed
@jpbusch jpbusch deleted the refactor/conversion branch July 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants