Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vite 5 to allowed peerDep versions #437

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

bensaufley
Copy link
Contributor

To be completely honest I'm not sure if this is all that's needed but it looks like the main thing is to conform to the vite Plugin interface and the changes from 4 to 5 there don't seem to have anything that applies to this repo.

To be completely honest I'm not sure if this is all that's needed but it looks like the main thing is to conform to the vite Plugin interface and the changes from 4 to 5 there don't seem to have anything that applies to this repo.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ikenfin ikenfin merged commit 400aa0b into ikenfin:master Feb 5, 2024
3 checks passed
@ikenfin
Copy link
Owner

ikenfin commented Feb 5, 2024

@bensaufley yeah, seems that plugin is fine with vite 5. Thanks!

@bensaufley bensaufley deleted the bs-allow-vite-5 branch February 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants