Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represented textual expression using CustomDebugStringConvertible. #193

Merged

Conversation

es-kumagai
Copy link
Contributor

@es-kumagai es-kumagai commented Dec 12, 2017

Represented textual expression using CustomDebugStringConvertible protocol instead of CustomStringConvertible protocol.

Motivation

This motivation is that I'd like to customize a text representation of DecodeError instance to displaying error message in my application. I tried to make DecodeError conform to CustomStringConvertible protocol, but it was already conformed to it, so I couldn't do that.

Express as a debug information

In addition, I think the textual expression of DecodeError that are provided by CustomStringConvertible seems to be debug information.

In this reason, I'd like to propose to express the information using CustomDebugStringConvertible protocol instead of CustomStringConvertible protocol.

For the same reason, I'd like to propose that to Extractor and KeyPath too.

…rotocol instead of `CustomStringConvertible` protocol.
@ikesyo
Copy link
Owner

ikesyo commented May 11, 2018

Sorry for the really late response 🙇

But this makes sense! Thanks for the pull request 👍

@ikesyo ikesyo merged commit 5f9a372 into ikesyo:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants