use long for internal counters #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @rr0gi will check today |
ikod
reviewed
Feb 13, 2022
source/cachetools/cache2q.d
Outdated
| @@ -162,7 +162,7 @@ class Cache2Q(K, V, Allocator=Mallocator) | |||
| /// | |||
| final int length() @safe | |||
| { | |||
| return _InMap.length + _OutMap.length + _MainMap.length; | |||
| return cast(int)(_InMap.length + _OutMap.length + _MainMap.length); | |||
There was a problem hiding this comment.
I'm not sure if this is good to convert long to int here. Should length() return long in this case?
There was a problem hiding this comment.
also I am not sure if changing visible type of cache2q.length is acceptable, hence the cast
I would return long (or even better change everything to ulong) :)
There was a problem hiding this comment.
This would require API change. this is ok, just have to change major version
|
rebased to master and removed cast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a hashmap of 250M+ elements, buckets_num overflows on resize (and thankfully asserts, unlike builtin aa which seems to just corrupt memory)
Idk if making it compile-time parameters is better option, or maybe using size_t
also I am not sure if changing visible type of cache2q.length is acceptable, hence the cast