Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support openssl 1.3 #158

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Support openssl 1.3 #158

merged 1 commit into from
Jun 16, 2023

Conversation

skoppe
Copy link
Contributor

@skoppe skoppe commented Jun 16, 2023

On latest ArchLinux it didn't run anymore...

@ikod ikod merged commit 8ecd4bc into ikod:master Jun 16, 2023
@ikod
Copy link
Owner

ikod commented Jun 16, 2023

Thanks!

@WebFreak001
Copy link
Contributor

I think this added support for openssl 3.1, no?

@skoppe
Copy link
Contributor Author

skoppe commented Jun 18, 2023

I think this added support for openssl 3.1, no?

The version I got was 1.3 though... That or this library mixed up the major/minor in here

return Version((v>>>20) & 0xff, (v>>>28) & 0xff);

@ikod
Copy link
Owner

ikod commented Jun 18, 2023

Sorry, I didn't tested this PR. Will try now.

@ikod
Copy link
Owner

ikod commented Jun 18, 2023

Can you please check latest commit?

@WebFreak001
Copy link
Contributor

at least the change added in this PR is important for things to start working on Ubuntu 22.04 with libssl-dev installed, where otherwise it would break without this PR applied (the 1,3 version)

@ikod
Copy link
Owner

ikod commented Jun 18, 2023

I pushed fixes, available tests passed. Please check

@WebFreak001
Copy link
Contributor

Micah on discord has been testing this for me and confirms it's still fixed with master right now, at least in their test case with attempting to start serve-d.

@ikod
Copy link
Owner

ikod commented Jun 19, 2023

Thanks! Will publish release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants