Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AddBaseTypePlugin): refreshing the history when add base type element #532

Merged
merged 16 commits into from
Nov 4, 2024

Conversation

GeorgeSmith215
Copy link
Contributor

@GeorgeSmith215 GeorgeSmith215 commented Oct 31, 2024

贡献者你好

很高兴你能付出自己的时间参与到vue-fabric-editor的共享当中去,相信很多人都因为你提交的代码而收益。

原则

我们希望每次提交尽量小,较大重构除外,确保我们每次的改动影响范围清晰明了,能够方便项目维护者快速的将代码合并到主分支。

确保你的代码与主仓库没有冲突

在PR前,请确保你的代码与主仓库保持同步,可以参考这篇文章

确保你的代码代码能正常打包构建

在PR前,请在本地进行打包构建,并进行功能测试,确保功能正常,且不影响其他功能。

  • 代码构建正常

告知项目维护者本次修改的功能

在添加基础类型元素时刷新历史记录
#374

GeorgeSmith and others added 16 commits August 12, 2024 17:35
# Conflicts:
#	packages/core/plugin/HistoryPlugin.ts
#	packages/core/utils/fabric-history.js
@nihaojob nihaojob merged commit 897c53b into ikuaitu:main Nov 4, 2024
1 check passed
@nihaojob
Copy link
Member

nihaojob commented Nov 4, 2024

感谢大佬 已合并到主分支

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants