Multi-account support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbu
reviewed
Aug 24, 2017
nameko_slack/rtm.py
Outdated
| self._client.server.rtm_connect() | ||
| def connect(self): | ||
| for bot_name, client in self.clients.items(): | ||
| client.server.rtm_connect() |
There was a problem hiding this comment.
True, no need for extra method .)
timbu
reviewed
Aug 24, 2017
nameko_slack/rtm.py
Outdated
| def handle(self, bot_name, event): | ||
| for provider in self._providers: | ||
| if provider.bot_name == bot_name: | ||
| provider.handle_event(event) |
There was a problem hiding this comment.
might be nice later to have stashed the handlers per bot-name (so we don't need to loop)
There was a problem hiding this comment.
You are right, this uses the ProviderCollector providers set, which the mixin takes care of. It's a trade of between simplicity and efficiency. This could be revisited later on, with making the providers a dictionary.
|
👍 nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ads the ability to run multiple RTM bots - each bot account having its own RTM client loop