Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module paths instead of conditional module includes for sys modules #330

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Nov 13, 2024

Saves 1 LOC

@joshka
Copy link
Contributor Author

joshka commented Nov 13, 2024

Hrm, this one seems to be trigger a lot of build failures. Maybe too many to worry about a single LOC :D

@ilai-deutel
Copy link
Owner

This is a great idea, and regardless of line count it also looks cleaner. I don't understand why the dead code warnings appear though, and only on Windows not Linux or Mac.

I don't know if it's an issue with the code or with the compiler, I may do some more testing with a Windows machine later :)

@ilai-deutel
Copy link
Owner

I just figured it out, I think the #[cfg(windows)] mod windows; line needs to be removed

@joshka joshka force-pushed the jm/cfg_attr branch 2 times, most recently from 93fc509 to d0e473d Compare November 19, 2024 04:16
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.41%. Comparing base (2a5840e) to head (6b40a4d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   48.33%   48.41%   +0.08%     
==========================================
  Files          10       10              
  Lines        1138     1138              
==========================================
+ Hits          550      551       +1     
+ Misses        588      587       -1     
Flag Coverage Δ
wasm32-wasip1 49.00% <ø> (ø)
x86_64-apple-darwin 49.09% <ø> (?)
x86_64-pc-windows-gnu 48.29% <ø> (ø)
x86_64-unknown-linux-gnu 49.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ilai-deutel
Copy link
Owner

FYI, I reported the misleading warning: rust-lang/rust#133197

@ilai-deutel ilai-deutel merged commit edcba19 into ilai-deutel:master Nov 19, 2024
26 checks passed
@joshka joshka deleted the jm/cfg_attr branch November 19, 2024 09:52
joshka added a commit to joshka/kibi that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants