Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export setupMSVCDevCmd to allow library usage #47

Merged
merged 1 commit into from
Sep 16, 2021
Merged

export setupMSVCDevCmd to allow library usage #47

merged 1 commit into from
Sep 16, 2021

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Sep 15, 2021

No description provided.

@aminya
Copy link
Contributor Author

aminya commented Sep 15, 2021 •
edited
Loading

@ilammy This exports the function that performs the installation. It allows me to use this function directly inside my setup-cpp action

ilammy
ilammy approved these changes Sep 16, 2021
View reviewed changes
Copy link
Owner

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure GitHub Actions are supposed to be used that way, but sure, why not vOv

@ilammy ilammy merged commit f456b80 into ilammy:master Sep 16, 2021
@ilammy
Copy link
Owner

ilammy commented Sep 16, 2021

@aminya, you don't need this to be published on npm or anywhere, as you'd just include this code via submodules, right?

@aminya aminya mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilammy ilammy ilammy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminya @ilammy