Skip to content

Commit

Permalink
Pin Android NDK version to 21.4.7075529
Browse files Browse the repository at this point in the history
GitHub Actions seems to experience some issues with detecting the right
Android NDK to use. There all sorts of hacks with "side-by-side"
installation and "ndk-bundle" which you can read about elsewhere.

Resolve this predicament by pinning the NDK version we are using for
building our native code, both BoringSSL and Themis JNI stuff.

This means developers will have to install this specific version of NDK
instead of using whatever they are using. But that's not a particular
issue. NDK does not affect compatibility of apps either, unless Google
really screws up and breaks something there. Not in our case though
since we're not really using anything Android-specific in our code.
  • Loading branch information
ilammy committed May 19, 2021
1 parent 2bf951c commit 6767e61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/wrappers/themis/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ dependencies {
android {
compileSdkVersion 28
buildToolsVersion "28.0.3"
ndkVersion "21.4.7075529"

// BoringSSL requires at least API 21. Google Play as of August 2019 requires
// to target at least API 28 (but we can still support lower versions).
Expand Down
1 change: 1 addition & 0 deletions third_party/boringssl/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ apply plugin: 'kotlin-android'
android {
compileSdkVersion 28
buildToolsVersion "28.0.3"
ndkVersion "21.4.7075529"

defaultConfig {
// BoringSSL requires at least API 21 to target AArch64. Google Play
Expand Down

0 comments on commit 6767e61

Please sign in to comment.