Refactor the command for creating a local development environment

[TomerFi]

No description provided.

[ilan-pinto]

good points

• i really liked the breakdown you made with the build.ts file
• i really liked the input process

in discussion point:

• using .then instead of await function buildLocalEnv created a very messy code that is hard to track or understand. IMO we should use async/await

• executeShellCommand should support sync and async.

[ilan-pinto]

this is less clean than using await.

[TomerFi]

I think so.
before, after each await statement, we needed to sleep,
using this callbacks technique, and we sleep no more.
:-)

[TomerFi]

also, with the awaits statements,
we dropped granular control of the displayed message.

we didn't handle rejected promises,
we just let them all drop into the catch clause of the try-catch statement.

now, using the catch callbacks, we handle rejections better at the time they arrive,
we have full control over what is being displayed to the user, and what is being done after the rejection.

if we were to try and do this with previous iteration using the await statements,
I'm guessing it wouldn't have looked all that well with a million try-catch/switch/if statements.
🤔

IMO
the use of the await statements was cool and pretty,
but, as it was, it didn't get half the work done as the current promise and callbacks technique,
so I'm not sure the two code iterations are comparable.
😃

[ilan-pinto]

but we could handle the rejection of the promise.
e.g
acceptJoinRequests rejection promise could also take care of

console.debug('failed to accept join requests');
console.error(stderr);
progressReporter({increment: 100 , message: 'failed to accept the join request made from the managed clusters'});
reject('OCM extension, failed to accept the join request made from the managed clusters');

[TomerFi]

@ilan-pinto

good points

• i really liked the breakdown you made with the build.ts file
• i really liked the input process

Thanks. :-)

in discussion point:

• using .then instead of await function buildLocalEnv created a very messy code that is hard to track or understand. IMO we should use async/await

I think it looks better this way, about the readability,
perhaps we can break it down into smaller functions and make it more readable,
or maybe emphasize the code documentation to make it clearer.

• executeShellCommand should support sync and async.

I should have pointed out, I fixed executeShellCommand.
you were correct, in its previous iteration it was blocking (my bug).
you added an async boolean argument and made it do both sync and async.
but now... it was modified, it's async for all.
:-)

[ilan-pinto]

doesn't need to be so big
// Initialize the Hub Cluster

could be enough

[ilan-pinto]

very good!
you can merge it to my branch