Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched key and value in forEach-callback? #18

Closed
littleant opened this issue Mar 12, 2020 · 0 comments
Closed

Switched key and value in forEach-callback? #18

littleant opened this issue Mar 12, 2020 · 0 comments

Comments

@littleant
Copy link
Contributor

I don't know if this is intentional, but the following line seems to be wrong:

shares.forEach((k, v) => {

forEach((k, v) => ...) should be forEach((v, k) => ...).
Below this line the share-value k is compared with the index x.

I currently don't understand the interpolate-function fully, but this doesn't look right to me.
A share is a binary blob, that is compared to an index, which is an integer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant