-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched key and value in forEach-callback? #18
Comments
ilap
added a commit
that referenced
this issue
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't know if this is intentional, but the following line seems to be wrong:
slip39-js/src/slip39_helper.js
Line 285 in 4d4675c
forEach((k, v) => ...)
should beforEach((v, k) => ...)
.Below this line the share-value
k
is compared with the indexx
.I currently don't understand the interpolate-function fully, but this doesn't look right to me.
A share is a binary blob, that is compared to an index, which is an integer...
The text was updated successfully, but these errors were encountered: