stop hiding exceptions #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
k-dominik
commented
Oct 26, 2023
excepthook was used before 2b09109 that claims segfaults being cause by it. Could not reproduce segfaults - and rather have an error message popping up. Otherwise in case of exception somewhere along the chain, ilastik looks like it's doing nothing and one wouldn't know.
k-dominik
force-pushed
the
stop-hiding-exc
branch
from
eda7eae to
f3ac824
Compare
btbest
approved these changes
Oct 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excepthook was used before in #251 2b09109 that claims segfaults being cause by it.
Could not reproduce segfaults - and rather have an error message popping up.
Otherwise in case of exception somewhere along the chain, ilastik looks like it's doing nothing and one wouldn't know.