Add support for categorical columns with NA #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anndata 0.7.8 exports categories with NA with a value -1, causing the reading of mudata/anndata to fail. This adds support for NAs. The convert_categoricals function is added as an internal function in order to facilitate testing of this logic. Fixes: ilia-kats#6
|
Looks good to me, thanks. CI is failing because of an issue in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anndata (eg 0.7.8) exports categorical colums with NA with a value -1, causing the reading of
mudata/anndatato fail (#6 ).This adds support for reading categorical columns with NAs.
The
convert_categoricalsfunction is added as an internal function in order to facilitate testing of this logic.Fixes: #6