Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Razor Configuration API. #169

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

ericburcham
Copy link

The interface is done, along with relevant unit tests. I'm landing the pull request now. I have to start moving to production with that ASAP in my local environment, but if you have constructive criticism, I'm happy to comply with your wishes.

In the meantime, here are the nuts and bolts of what I did.

  • There is only one interface involved: IProvideReportConfiguration. It is implement by ReportConfigurationProvider.
  • There is an overloaded constructor in MvcReportViewerIframe, which takes an instance of IProvideReportConfiguration.
  • There is a new extension method in MvcReportViewerExtensions which takes an instance of IProvideReportConfiguration.
  • As a curiosity, it would up NOT being part of the fluent API, because… what for? There is only one call… @Html.MvcReportViewer(configuration);
  • Also, worth noting, I have created a MockHelpers class that allows you to mock a decent HttpContext, including the current Session… necessary for test coverage of calls to ILocalReportDataSourceProvider.Add.
  • Finally, I removed the generics on the calls to ILocalReportDataSourceProvider.Add(). They were unnecessary, and don't provide any value to the caller. This let me deal with a collection of data sources in IProvideReportConfiguration.

…xamples project. Also created a separate solution for it so as not to cause problems opening the primary one for users with SSDT installed.
…ng around with .gitattributes configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants