fix(server): Log internal errors to the console

ilijaNL · Oct 19, 2021 · 6ddf0d1 · 6ddf0d1
1 parent 8d13c9e
commit 6ddf0d1
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 0 deletions.
diff --git a/src/__tests__/client.ts b/src/__tests__/client.ts
@@ -15,6 +15,17 @@ import {
 import { startWSTServer as startTServer } from './utils';
 import { ExecutionResult } from 'graphql';
 
+// silence console.error calls for nicer tests overview
+const consoleError = console.error;
+beforeAll(() => {
+  console.error = () => {
+    // silence
+  };
+});
+afterAll(() => {
+  console.error = consoleError;
+});
+
 // simulate browser environment for easier client testing
 beforeEach(() => {
   Object.assign(global, {

diff --git a/src/__tests__/server.ts b/src/__tests__/server.ts
@@ -19,6 +19,17 @@ import {
 import { schema, schemaConfig } from './fixtures/simple';
 import { createTClient, startWSTServer as startTServer } from './utils';
 
+// silence console.error calls for nicer tests overview
+const consoleError = console.error;
+beforeAll(() => {
+  console.error = () => {
+    // silence
+  };
+});
+afterAll(() => {
+  console.error = consoleError;
+});
+
 /**
  * Tests
  */

diff --git a/src/__tests__/use.ts b/src/__tests__/use.ts
@@ -17,6 +17,17 @@ import {
   FastifyExtra,
 } from './utils';
 
+// silence console.error calls for nicer tests overview
+const consoleError = console.error;
+beforeAll(() => {
+  console.error = () => {
+    // silence
+  };
+});
+afterAll(() => {
+  console.error = consoleError;
+});
+
 for (const { tServer, startTServer } of tServers) {
   describe(tServer, () => {
     it('should allow connections with valid protocols only', async () => {

diff --git a/src/use/fastify-websocket.ts b/src/use/fastify-websocket.ts
@@ -92,6 +92,11 @@ export function makeHandler<
             try {
               await cb(String(event));
             } catch (err) {
+              console.error(
+                'Internal error occurred during message handling. ' +
+                  'Please check your implementation.',
+                err,
+              );
               socket.close(
                 CloseCode.InternalServerError,
                 // close reason should fit in one frame https://datatracker.ietf.org/doc/html/rfc6455#section-5.2

diff --git a/src/use/uWebSockets.ts b/src/use/uWebSockets.ts
@@ -189,6 +189,11 @@ export function makeBehavior<
       try {
         await client.handleMessage(Buffer.from(message).toString());
       } catch (err) {
+        console.error(
+          'Internal error occurred during message handling. ' +
+            'Please check your implementation.',
+          err,
+        );
         socket.end(
           CloseCode.InternalServerError,
           // close reason should fit in one frame https://datatracker.ietf.org/doc/html/rfc6455#section-5.2

diff --git a/src/use/ws.ts b/src/use/ws.ts
@@ -110,6 +110,11 @@ export function useServer<
             try {
               await cb(String(event));
             } catch (err) {
+              console.error(
+                'Internal error occurred during message handling. ' +
+                  'Please check your implementation.',
+                err,
+              );
               socket.close(
                 CloseCode.InternalServerError,
                 // close reason should fit in one frame https://datatracker.ietf.org/doc/html/rfc6455#section-5.2