Fix Issue exceljs#488 where dt is an invalid date format. Check the v…

…alue and return blank string. Add unit test.
ilijaz · Jun 11, 2018 · b5336ca · b5336ca
1 parent 832c441
commit b5336ca
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/xlsx/xform/simple/date-xform.js b/lib/xlsx/xform/simple/date-xform.js
@@ -13,7 +13,10 @@ var DateXform = module.exports = function(options) {
   this.tag = options.tag;
   this.attr = options.attr;
   this.attrs = options.attrs;
-  this._format = options.format || function(dt) { return dt.toISOString(); };
+  this._format = options.format || function(dt) {
+    if (isNaN(dt.getTime())) return '';
+    return dt.toISOString();
+  };
   this._parse = options.parse || function(str) { return new Date(str); };
 };
 

diff --git a/spec/unit/xlsx/xform/simple/date-xform.spec.js b/spec/unit/xlsx/xform/simple/date-xform.spec.js
@@ -33,7 +33,16 @@ var expectations = [
     preparedModel: undefined,
     xml: '',
     tests: ['render', 'renderIn']
+  },
+  {
+    title: 'invalid date',
+    create: function() { return new DateXform({tag: 'date', attr: undefined}); },
+    preparedModel: new Date(undefined),
+    xml: '<date />',
+    tests: ['render']
   }
+
+
 ];
 
 describe('DateXform', function() {