rm unnecessary slicing of ember-data collections into arrays.

packages/ilios-common/addon/components/course/visualize-instructor-session-type-graph.js

@@ -64,7 +64,7 @@ export default class CourseVisualizeInstructorSessionTypeGraph extends Component
   }
 
   async getData(course, user) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
     if (!sessions.length) {
       return [];
     }

packages/ilios-common/addon/components/course/visualize-instructor-term-graph.js

@@ -65,7 +65,7 @@ export default class CourseVisualizeInstructorTermGraph extends Component {
   }
 
   async getData(course, user) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
     if (!sessions.length) {
       return [];
     }
@@ -75,7 +75,8 @@ export default class CourseVisualizeInstructorTermGraph extends Component {
     });
 
     const sessionsWithTerms = await map(sessionsWithUser, async (session) => {
-      const terms = await map((await session.terms).slice(), async (term) => {
+      const sessionTerms = await session.terms;
+      const terms = await map(sessionTerms, async (term) => {
         const vocabulary = await term.vocabulary;
         return {
           term,

packages/ilios-common/addon/components/course/visualize-instructors-graph.js

@@ -84,7 +84,7 @@ export default class CourseVisualizeInstructorsGraph extends Component {
   }
 
   async getData(course) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
     const sessionsWithInstructors = await map(sessions, async (session) => {
       const instructors = await session.getAllInstructors();
       const instructorsWithInstructionalTime = await map(instructors, async (instructor) => {

packages/ilios-common/addon/components/course/visualize-objectives-graph.js

@@ -23,7 +23,7 @@ export default class CourseVisualizeObjectivesGraph extends Component {
   }
 
   get sessions() {
-    return this.sessionsData.isResolved ? this.sessionsData.value.slice() : [];
+    return this.sessionsData.isResolved ? this.sessionsData.value : [];
   }
 
   @cached

packages/ilios-common/addon/components/course/visualize-session-type-graph.js

@@ -65,8 +65,8 @@ export default class CourseVisualizeSessionTypeGraph extends Component {
   }
 
   async getDataObjects(course, sessionType) {
-    const sessions = (await course.sessions).slice();
-    const sessionTypeSessions = (await sessionType.sessions).slice();
+    const sessions = await course.sessions;
+    const sessionTypeSessions = await sessionType.sessions;
 
     const courseSessionsWithSessionType = sessions.filter((session) =>
       sessionTypeSessions.includes(session),
@@ -81,7 +81,7 @@ export default class CourseVisualizeSessionTypeGraph extends Component {
     });
 
     const termData = await map(sessionsWithMinutes, async ({ session, minutes }) => {
-      const terms = (await session.terms).slice();
+      const terms = await session.terms;
       return map(terms, async (term) => {
         const vocabulary = await term.vocabulary;
         return {

packages/ilios-common/addon/components/course/visualize-session-types-graph.js

@@ -83,7 +83,7 @@ export default class CourseVisualizeSessionTypesGraph extends Component {
   }
 
   async getData(course) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
 
     if (!sessions.length) {
       return [];

packages/ilios-common/addon/components/course/visualize-term-graph.js

@@ -64,7 +64,7 @@ export default class CourseVisualizeTermGraph extends Component {
   }
 
   async getDataObjects(course, term) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
     const sessionIds = term.hasMany('sessions').ids();
     const filteredSessions = sessions.filter((session) => sessionIds.includes(session.id));
     const sessionTypes = await Promise.all(filteredSessions.map((s) => s.sessionType));

packages/ilios-common/addon/components/course/visualize-vocabularies-graph.js

@@ -66,7 +66,7 @@ export default class CourseVisualizeVocabulariesGraph extends Component {
   }
 
   async getDataObjects(course) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
     if (!sessions.length) {
       return [];
     }
@@ -82,7 +82,7 @@ export default class CourseVisualizeVocabulariesGraph extends Component {
     const sessionWithMinutesAndVocabs = await map(
       sessionsWithMinutes,
       async ({ session, minutes }) => {
-        const terms = (await session.terms).slice();
+        const terms = await session.terms;
         const vocabularies = await all(mapBy(terms, 'vocabulary'));
         return {
           session,

packages/ilios-common/addon/components/course/visualize-vocabulary-graph.js

@@ -65,7 +65,7 @@ export default class CourseVisualizeVocabularyGraph extends Component {
   }
 
   async getDataObjects(course) {
-    const sessions = (await course.sessions).slice();
+    const sessions = await course.sessions;
     if (!sessions.length) {
       return [];
     }