adds downloadable data sheets for course visualizations #8218
Conversation
stopfstedt
force-pushed
the
download_data_sheets_course_viz
branch
2 times, most recently
from
9b1a112 to
ea686da
Compare
stopfstedt
force-pushed
the
download_data_sheets_course_viz
branch
from
8d841f0 to
dd3c328
Compare
…e used there, too.
this gives some room to right-aligned components within, such as download buttons.
stopfstedt
force-pushed
the
download_data_sheets_course_viz
branch
from
dd3c328 to
7a5d750
Compare
…, then declare it in apps consuming common as dev-dep.
not much we can test here - the download action itself is not testable. so we're checking for the presence of the d/l button only.
the button won't be on the screen if there's no data, so disabling it is pointless.
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
There was a problem hiding this comment.
I tried all four visualization types for https://deploy-preview-8218--ilios-frontend.netlify.app/data/courses/2224 and the download buttons all worked (in Chrome and Firefox) as expected. The Objectives one, however, put raw HTML markup into the Course Objective column, which may not be what you were intending.
Thank Mike, I'll take this back to the workbench for markup stripping. Should be back with it shortly. |
No description provided.