Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces ember-render-modifiers in curr inv report rollover component. #8261

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented Dec 7, 2024

refs ilios/ilios#5374

i think this one is ready to go, but i'm leaving it in draft for now, so i can add more to the rather spotty component test coverage. handled.

@stopfstedt stopfstedt force-pushed the replace_render_modifiers_in_curr_inv_report_rollover_component branch from ebdfe50 to 86f9abd Compare December 9, 2024 16:38
@stopfstedt stopfstedt marked this pull request as ready for review December 9, 2024 17:15
michaelchadwick
michaelchadwick previously approved these changes Dec 9, 2024
Copy link
Contributor

@michaelchadwick michaelchadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad.

@stopfstedt stopfstedt force-pushed the replace_render_modifiers_in_curr_inv_report_rollover_component branch from 8d6f709 to 0a82b3c Compare December 10, 2024 15:55
@michaelchadwick michaelchadwick self-requested a review December 10, 2024 21:36
@dartajax dartajax added the run ui tests Run the expensive UI tests label Dec 10, 2024
@dartajax dartajax merged commit 4a5c1d9 into ilios:master Dec 11, 2024
42 checks passed
@stopfstedt stopfstedt deleted the replace_render_modifiers_in_curr_inv_report_rollover_component branch December 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants