Replace render modifiers in curr inv sequence block overview component #8265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while at it, i moved some functions/tasks around to group related concepts closer for improved DX. load() task went on top so i don't have to scroll that much while taking it apart.
all this just to get the course details of the current course selection - if there is one - , or the course already associated with the sequence block, correctly onto the screen. i hate this, but can't come up with a better way of handling this multi-state situation. speaking of which - the course details should probably be its own component now, will deal with that later.
this pulls out the loading of the sequence block parent and the block's siblings as well.
… the constructor instead of load()
…method() form validation is hinky for these two, as it was before. there's a slight change in behaviour here - if both are in edit-mode and you save one, the other one closes as well. infuriating! might as well lock one down while the other is in edit-mode. that's probably going to be the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still work in progress.