Fully Lock Ember Data #8336
Merged
Fully Lock Ember Data #8336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
relock-ember-data
branch
from
c65be27 to
2b0cd5c
Compare
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
stopfstedt
approved these changes
Feb 10, 2025
Some of the ED dependencies were allowed to install updates which breaks when anything gets updated. Lock everything together and update everything at the same time.
There is some instability between this and ember-data in v4. Locking it at v3 temporarily to restore our ability to upgrade.
jrjohnson
force-pushed
the
relock-ember-data
branch
from
2b0cd5c to
59cb989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the ED dependencies were allowed to install updates which breaks when anything gets updated. Lock everything together and update everything at the same time.
This was further complicated by an update to
@ember/test-waiterswhich doesn't work with our pinned ember-data version. Locking that as well.