Self validate LTI Request #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this by in the dev environment with UCSF Moodle and it works, I think it's ready for merging. |
stopfstedt
approved these changes
Apr 18, 2019
The one we are using is no longer maintained.
We don't have any need for the token at this point since we're validating a OAuth request that doesn't have one yet, but relying on consumers of this function to remember to append an empty & is not a good idea (since I forgot the first time). Instead I've added a token parameter which can be passed in blank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes our dependence on https://github.com/omsmith/ims-lti which has been abandoned. Unfortunately there doesn't seem to be a good replacement. Once we've tested this in production it might be worth extracting for general publication.