Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi4py workaround #585

Merged
merged 1 commit into from
Dec 27, 2021
Merged

mpi4py workaround #585

merged 1 commit into from
Dec 27, 2021

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Dec 26, 2021 •
edited
Loading

@matthiasdiener matthiasdiener changed the title Update install.sh mpi4py workaround Dec 26, 2021
@matthiasdiener matthiasdiener mentioned this pull request Dec 26, 2021
Merged
@matthiasdiener
Copy link
Member Author

@inducer: What is your opinion on this PR vs #584? This PR seems to be a bit simpler, but does not explicitly address Cython (which I'm not sure how important it is).

@inducer
Copy link
Contributor

inducer commented Dec 26, 2021

I like the simplicity of this, but it doesn't seem to address the Cython issue for Emirge and production? Though TBH I'm not sure I understand why #584 would. Let me rerun the CI for it, to maybe level the playing field/understand better.

@matthiasdiener
Copy link
Member Author

I like the simplicity of this, but it doesn't seem to address the Cython issue for Emirge and production? Though TBH I'm not sure I understand why #584 would. Let me rerun the CI for it, to maybe level the playing field/understand better.

I think Emirge/production need illinois-ceesd/emirge#143 to pass and would be hopefully fine when that merges. CI has been super-flaky lately for some reason...

@inducer
Copy link
Contributor

inducer commented Dec 27, 2021

If that works, then I think that's perfect. I forgot to approve illinois-ceesd/emirge#143, did that just now. Depending on CI flakiness, it might merge soon, and we can try this out.

@inducer inducer mentioned this pull request Dec 27, 2021
Closed
@inducer inducer marked this pull request as ready for review December 27, 2021 17:02
inducer
inducer approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works. Thanks for for figuring this out!

@inducer inducer enabled auto-merge (squash) December 27, 2021 17:03
@inducer inducer merged commit 6ae2890 into main Dec 27, 2021
@inducer inducer deleted the mpi4py-workaround branch December 27, 2021 17:03
matthiasdiener added a commit that referenced this pull request Feb 8, 2022
@matthiasdiener
Revert "Work around mpi4py installation issues from setuptools vendor…
98d4956 
…ing distutils (#585)"

This reverts commit 6ae2890.

The underlying setuptools bug has been fixed:
pypa/setuptools#2987
@matthiasdiener matthiasdiener mentioned this pull request Feb 8, 2022
Merged
matthiasdiener added a commit that referenced this pull request Feb 9, 2022
@matthiasdiener
Revert "Work around mpi4py installation issues from setuptools vendor…
dc79645 
…ing distutils (#585)" (#604)

This reverts commit 6ae2890.

The underlying setuptools bug has been fixed:
pypa/setuptools#2987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer inducer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasdiener @inducer