-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Flesh out and add a simple description #17
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rich, thank you for taking the time to give some details on the IPD process. Overall I find this to be a major improvement to what we currently have, so feel free to ignore any and all comments I've made in the spirit of getting something better out there.
impact) project wishing to make changes to illumos. They should describe the | ||
what and the why and give people the opportunity to comment on both. | ||
|
||
An IPD is at its heart, just a README.md in a numbered directory in this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm the only one who did an .adoc, haha. I'd say we should allow either. And if that's the case maybe rephrase this like "An IPD consists of either a markdown or asciidoc README file in a numbered directory".
long-term project that will likely integrate in pieces, to provide the overall | ||
picture. | ||
|
||
For your first contribution, you might want to just submit a pull request to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your first contribution, you might want to just submit a pull request to | |
For your first contribution, you should submit a pull request to |
[@jclulow](https://github.com/jclulow) or open an issue against this | ||
repository. | ||
Contributions are welcome. A good rule of thumb as to whether you _should_ | ||
have an IPD is whether you are making a change with high impact to other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have an IPD is whether you are making a change with high impact to other | |
write an IPD is whether you are making a change with high impact to other |
|
||
For your first contribution, you might want to just submit a pull request to | ||
this repository. Going forward if this is a thing that you will do again, | ||
we'll probably give you write access to this repository so you can just add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll probably give you write access to this repository so you can just add | |
we'll probably give you write access to this repository so you can add |
#### predraft | ||
|
||
You've started writing your IPD and you want to share it narrowly, or even | ||
just to reserve your a number in this repository. You're _predraft_, maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to reserve your a number in this repository. You're _predraft_, maybe | |
just to reserve a number in this repository. You're _predraft_, maybe |
"Sponsor" is a weird word here, it's just the person or people on the illumos | ||
core team who were ok with your IPD. Don't worry about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rich, first I want to be clear I'm happy someone took the time to flesh out the IPD process a bit. But I can't help but read this and wonder why we even have sponsorship if it's something no one should worry about and it's "weird"? If we can't explain what it is to the general public, maybe we don't need it?
It seems like the sponsor is the illumos core member who agreed the IPD should be moved to the published state? If so that seems easy enough to explain.
No description provided.