New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shiro-550 CVE-2016-4437 #26

Open

bigsizeme wants to merge 2 commits into ilmila:master from bigsizeme:master

bigsizeme commented Jun 16, 2020

The code is not very standardized, you can modify it. Thank you

bigsizeme and others added 2 commits

June 16, 2020 16:51


          add shiro-550 CVE-2016-4437

889624b


          modify code

4030c21

Owner

ilmila commented Jun 29, 2020

Thank you for the PR.

I have few comments:

The check will run even if the remote target does not have Apache Shiro library. Is it possible to add a detection check for Apache Shiro? So the check for the CVE-2016-4437 runs only if the framework is detected?
Could you please clean up the code, removing the unused comments and insert some functional comments regarding the detection strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet