Add thin disk provisioning & unit number to solve error

[0dragosh]

This PR adds thin disk provisioning as optional and disk unit number to solve this issue.

[0dragosh]

@ilpozzd I don't know how open you are to receiving PRs but I have just started using your module with talos and vsphere, it's great 👍🏻
I thought I'd contribute since I may have some specific needs & already have terraform experience, hope this is ok.

[ilpozzd]

@0dragosh, thanks for PR! I will update this module in the coming days. The Talos configuration transformation will be moved to a separate module so that the resulting userdata can be used in any cloud that supports it.

[0dragosh]

@ilpozzd awesome! Cheers!

[ilpozzd]

@0dragosh, I tested your solution and unfortunately setting the thin_provisioned and eagerly_scrub parameters has no effect, because when cloning a virtual machine from OVF, the parameters that are specified there are used. In addition, setting these parameters will lead to the fact that when trying to update the infrastructure, a false re-creation of the machine will be caused (since the thin_provisioned and eagerly_scrub parameters are specified in the code alone, while others were created from OVF). So you need to specify statically the parameters so that they match those in OVF (thin_provisioned = false, eagerly_scrub = false)

[0dragosh]

@ilpozzd did you test with a second disk that's not in the OVF? My use case is a second data disk for storage.

[ilpozzd]

@0dragosh, I can change the data structure by adding one block for a basic fixed disk (like in OVF) and a dynamic block for all others

[0dragosh]

@ilpozzd That's what I was trying to achieve but I'm not that great with VMware. Thanks!

[ilpozzd]

@0dragosh, I found the better solution :)

thin_provisioned = index(var.disks, disk.value) == 0 ? false : lookup(disk.value, "thin_provisioned", false)

[0dragosh]

Looks good!