Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use DESTDIR properly in the Makefile and introduce PREFIX #220

Merged
merged 1 commit into from
Nov 25, 2023
Merged

fix: Use DESTDIR properly in the Makefile and introduce PREFIX #220

merged 1 commit into from
Nov 25, 2023

Conversation

Conan-Kudo
Copy link
Contributor

This allows for packaging tooling to use the Makefile properly.

@ilya-zlobintsev
Copy link
Owner

Am I understanding this right: after this change, the install options for packaging will be:

DESTDIR=${pkgdir} PREFIX=/usr make install

Also, the packaging script needs to be updated.

@Conan-Kudo
fix: Use DESTDIR properly in the Makefile and introduce PREFIX
6d3564d 
This allows for packaging tooling to use the Makefile properly.
@Conan-Kudo
Copy link
Contributor Author

Yes, and I just fixed the recipe file.

@ilya-zlobintsev
Copy link
Owner

Thanks!

@ilya-zlobintsev ilya-zlobintsev merged commit e9229ad into ilya-zlobintsev:master Nov 25, 2023
8 checks passed
@Conan-Kudo Conan-Kudo deleted the fix-makefile branch November 25, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conan-Kudo @ilya-zlobintsev