feat: add alternative headless and libadwaita builds #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-zlobintsev
force-pushed
the
alternative-libadwaita
branch
from
b84fb39
to
7419a7f
Compare
ilya-zlobintsev
force-pushed
the
alternative-libadwaita
branch
from
7419a7f
to
fe2fe8a
Compare
ilya-zlobintsev
force-pushed
the
alternative-libadwaita
branch
from
aa2b7e2
to
6278025
Compare
GabMus
reviewed
Dec 2, 2023
Comment on lines
23
to
25
| - name: Set libadwaita target | ||
| if: contains(matrix.target-os, 'libadwaita') | ||
| run: sed -i 's/\&\& make/\&\& make build-release-libadwaita/g' pkg/recipes/lact/recipe.yml |
There was a problem hiding this comment.
woulnd't it be better to keep the original recipe intact and just create another one for libadwaita?
There was a problem hiding this comment.
I'm trying to avoid the duplicate build steps between the recipes, ideally this would be done by passing some build flag when building the package, but unfortunately it doesn't seem possible
There was a problem hiding this comment.
I've ended up creating separate recipes after all so it's easier to manage
ilya-zlobintsev
force-pushed
the
alternative-libadwaita
branch
from
77c1db2
to
a4c1f3f
Compare
ilya-zlobintsev
changed the title
GabMus
approved these changes
Dec 9, 2023
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.