feat: implement historical charts window #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-transparent color
|
cc @In-line |
|
Thanks for taking your time to finish my work. I'm on a bit of hiatus now, as I have issues in finding time or motivation to contribute more. I will take a look at PR in few days. But please, be welcome to meld it in your opinioted way, without waiting for my opinion, as it may take a while. Thanks for being amazing maintainer and shaping LACT into something I use daily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #283 and the ideas discussed in #283 (comment), except the graphs are in a separate window and show more information.
The window can be opened either through the dropdown menu or a big button in the OC page.
The plotting logic is mostly unchanged since #283, except the value now gets modified directly instead of being sent over a GTK property as a JSON value.
The labels in the plot legend sometimes slightly clip through their container - I couldn't figure out how to fix this.