Add Rails 7 support #204
Add Rails 7 support #204
Conversation
* cleanup old rails versions support * add support Rails 7 version
Hi @ilyakatz I only meant that we familiarizated with the conversation from that PR and took into account your wish to save support for rails 5.2 |
|
sorry, still confused, the other PR also has support for 5.2, so are you saying two PR's do the same thing? You seem to be making better progress so if you think your PR does everything, I can ask #198 to close their PR in favor of yours |
|
Yes, we have kept the rails support from 5.2 and up. It seems to us that we have already completed the upgrade of this gem. If you have any comments or suggestions for what we can improve, let us know and we will finalize it. |
lib/data_migrate/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module DataMigrate | |||
| VERSION = "7.0.2".freeze | |||
| VERSION = "7.1.0".freeze | |||
There was a problem hiding this comment.
since this is removing support for older versions of rails, this is a non-backward compatible change so it would need to be a major version bump. Also I think it should be a release candidate so that folks can test it out. So I think it should be 8.0.0.rc1
There was a problem hiding this comment.
Good point, thanks. Done
|
Ok, sounds good. Just one small comment and after that we can deploy a release candidate version. After people try it out and we don't see any new reports, we can upgrade it to full major release versin |
|
sorry, one last thing, can you update https://github.com/ilyakatz/data-migrate/blob/master/Changelog.md and we'll be ready to go |
|
@ilyakatz Now that the changelog is added can we release the RC candidate? |
|
Merged, RC version is up on Rubygems! Once again, thanks for the PR! |
Hi everyone!
According this conversation #198 we removed support for older versions of rails <5.2 and added support for 7 rails. We passed all the tests.
@ilyakatz could you please review this?