Upstream and allow engines #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fndsit/allow engines
ilyakatz
reviewed
Mar 18, 2023
|
|
||
| DEFAULT_DATA_TEMPLATE_PATH = "data_migration.rb" | ||
|
|
||
| def initialize | ||
| @data_migrations_path = "db/data/" | ||
| @data_migrations_gen_path = "db/data" |
There was a problem hiding this comment.
what does gen stand for? do you mind adding it to the docs as well. also, please rebase with main, at some point travisci tests stopped running to i switched to github actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update which fixes the failing tests in #225 as well as ensures that the data rake tasks run successfully when there are multiple migration paths due to engines also using data migrations.
another alternative here is to install the migrations into the host application, which is how i believe schema migrations work. open to thoughts on strategy here!