Skip to content

Commit

Permalink
Explicitly depend on version-matched plugins in native packages. (net…
Browse files Browse the repository at this point in the history
…data#15861)

* Explicitly depend on version-matched plugins in native packages.

This should allow in-place downgrades of our native packages, starting
from versions after this change is introduced.

* Fix deps in Debian control file.
  • Loading branch information
Ferroin authored Aug 22, 2023
1 parent e47f21d commit ebf5211
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 25 deletions.
24 changes: 12 additions & 12 deletions contrib/debian/control
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ Architecture: any
Depends: openssl,
${misc:Depends},
${shlibs:Depends},
netdata-plugin-ebpf [amd64],
netdata-plugin-apps,
netdata-plugin-pythond,
netdata-plugin-go,
netdata-plugin-debugfs,
netdata-plugin-nfacct,
netdata-plugin-chartsd,
netdata-plugin-slabinfo,
netdata-plugin-perf
netdata-plugin-ebpf (= ${source:Version}) [amd64],
netdata-plugin-apps (= ${source:Version}),
netdata-plugin-pythond (= ${source:Version}),
netdata-plugin-go (= ${source:Version}),
netdata-plugin-debugfs (= ${source:Version}),
netdata-plugin-nfacct (= ${source:Version}),
netdata-plugin-chartsd (= ${source:Version}),
netdata-plugin-slabinfo (= ${source:Version}),
netdata-plugin-perf (= ${source:Version})
Pre-Depends: adduser,
dpkg (>= 1.17.14),
libcap2-bin (>=1:2.0),
Expand All @@ -53,9 +53,9 @@ Conflicts: netdata-core,
netdata-plugins-bash,
netdata-plugins-python,
netdata-web
Suggests: netdata-plugin-cups,
netdata-plugin-freeipmi
Recommends: netdata-plugin-systemd-journal
Suggests: netdata-plugin-cups (= ${source:Version}),
netdata-plugin-freeipmi (= ${source:Version})
Recommends: netdata-plugin-systemd-journal (= ${source:Version})
Description: real-time charts for system monitoring
Netdata is a daemon that collects data in realtime (per second)
and presents a web site to view and analyze them. The presentation
Expand Down
27 changes: 14 additions & 13 deletions netdata.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -136,24 +136,24 @@ Requires(pre): /usr/sbin/useradd
# makes it impossible to properly test the packages prior to upload,
# so we just skip depending on them on CentOS 7.
%if 0%{?_have_ebpf}
Requires: netdata-plugin-ebpf
%endif
Requires: netdata-plugin-apps
Requires: netdata-plugin-pythond
Requires: netdata-plugin-go
Requires: netdata-plugin-debugfs
Requires: netdata-plugin-chartsd
Requires: netdata-plugin-slabinfo
Requires: netdata-plugin-perf
Requires: netdata-plugin-ebpf = %{version}
%endif
Requires: netdata-plugin-apps = %{version}
Requires: netdata-plugin-pythond = %{version}
Requires: netdata-plugin-go = %{version}
Requires: netdata-plugin-debugfs = %{version}
Requires: netdata-plugin-chartsd = %{version}
Requires: netdata-plugin-slabinfo = %{version}
Requires: netdata-plugin-perf = %{version}
%if 0%{?_have_nfacct}
Requires: netdata-plugin-nfacct
Requires: netdata-plugin-nfacct = %{version}
%endif
%if 0%{?_have_freeipmi} && 0%{?centos_ver} != 6 && 0%{?centos_ver} != 7 && 0%{?amazon_linux} != 2
Suggests: netdata-plugin-freeipmi
Suggests: netdata-plugin-freeipmi = %{version}
%endif
%if 0%{?centos_ver} != 6 && 0%{?centos_ver} != 7 && 0%{?amazon_linux} != 2
Suggests: netdata-plugin-cups
Recommends: netdata-plugin-systemd-journal
Suggests: netdata-plugin-cups = %{version}
Recommends: netdata-plugin-systemd-journal = %{version}
%endif


Expand Down Expand Up @@ -919,6 +919,7 @@ fi
%caps(cap_dac_read_search=ep) %attr(0750,root,netdata) %{_libexecdir}/%{name}/plugins.d/systemd-journal.plugin

%changelog
* Mon Aug 21 2023 Austin Hemmelgarn <austin@netdata.cloud> 0.0.0-22
* Thu Aug 03 2023 Austin Hemmelgarn <austin@netdata.cloud> 0.0.0-21
- Added systemd-journal plugin handling
* Wed Jun 14 2023 Konstantin Shalygin <k0ste@k0ste.ru> 0.0.0-20
Expand Down

0 comments on commit ebf5211

Please sign in to comment.