ci: rate limit #327
ci: rate limit #327
Conversation
|
@mithro, according to actions/runner-images#602 the rate limit issue with macOS jobs is because "all macOS VMs have the same IP". The recommended solution is using the default token, as proposed in this PR. |
| @@ -47,5 +47,7 @@ jobs: | |||
| ln -s $(which python) /usr/bin/python3 | |||
|
|
|||
| - run: python ./get-toolchain.py | |||
| env: | |||
| GH_TOKEN: ${{ github.token }} | |||
There was a problem hiding this comment.
Does this need to be marked as a "secure" environment variable or something?
There was a problem hiding this comment.
No. It is secure, by itself. That is, the content of github.token depends on the context. If it is executed after someone with write privileges pushed a commit, it has some permissions. If it is executed in a fork, it has the permissions of the forker. If it is executed in a PR, it has read permissions but not write permissions.
This is not a Personal Access Token, which you would need to add to the "Secrets" in the settings of the repo, but it is a secret.
There was a problem hiding this comment.
In GitHub Actions a token is available by default (
${{ github.token }}, see https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions#github-context). At the same time,get-toolchain.pyexpects an envvar namedGH_TOKEN. In this PR, the envvar is set, so that authentication is used. This will hopefully reduce rate limit issues.