Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where you might have a GetThing() that concurrently does:
Using this pkg to put a Lock around the miss part can make sure we don't repeat expensive work from concurrent calls both seeing a miss. With the Lock though you'd want to check after the lock is entered if we are already cached since we could have just waited on a concurrent caller that set the cache.
So it would be:
The added
waited
return var can allow a skipping of the extra check ifwaited=false
.