Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar line shadow crash when we have only one (or zero) spot, #1466 #1485

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

imaNNeo
Copy link
Owner

@imaNNeo imaNNeo commented Nov 11, 2023

Fixes #1466

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #1485 (db94a90) into master (c8dc3c0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   86.62%   86.63%           
=======================================
  Files          45       45           
  Lines        3014     3015    +1     
=======================================
+ Hits         2611     2612    +1     
  Misses        403      403           
Files Coverage Δ
lib/src/chart/line_chart/line_chart_painter.dart 92.06% <100.00%> (+0.01%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@imaNNeo imaNNeo merged commit ba68c76 into master Nov 12, 2023
6 checks passed
@imaNNeo imaNNeo deleted the bugfix/line-shadow-crash branch November 12, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LineChartBarData crash if shadow applied on iOS
1 participant